This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ob/pushed] C++: Initialize a couple const globals
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 21 Aug 2015 23:50:35 +0100
- Subject: [ob/pushed] C++: Initialize a couple const globals
- Authentication-results: sourceware.org; auth=none
In C++ mode, we get:
src/gdb/gdbserver/tdesc.c:43:33: error: uninitialized const âdefault_descriptionâ [-fpermissive]
static const struct target_desc default_description;
^
In file included from src/gdb/gdbserver/tdesc.c:19:0:
src/gdb/gdbserver/tdesc.h:26:8: note: âconst struct target_descâ has no user-provided default constructor
struct target_desc
^
gdb/ChangeLog:
2015-08-21 Pedro Alves <palves@redhat.com>
* frame.c (null_frame_id): Explicitly zero-initialize.
gdb/gdbserver/ChangeLog:
2015-08-21 Pedro Alves <palves@redhat.com>
* tdesc.c (default_description): Explicitly zero-initialize.
---
gdb/ChangeLog | 4 ++++
gdb/frame.c | 2 +-
gdb/gdbserver/ChangeLog | 4 ++++
gdb/gdbserver/tdesc.c | 2 +-
4 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e99ec92..94bb7a5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-08-21 Pedro Alves <palves@redhat.com>
+
+ * frame.c (null_frame_id): Explicitly zero-initialize.
+
2015-08-21 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (struct dwarf2_section_info): Rename field
diff --git a/gdb/frame.c b/gdb/frame.c
index f05f739..745e007 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -503,7 +503,7 @@ frame_unwind_caller_id (struct frame_info *next_frame)
return null_frame_id;
}
-const struct frame_id null_frame_id; /* All zeros. */
+const struct frame_id null_frame_id = { 0 }; /* All zeros. */
const struct frame_id outer_frame_id = { 0, 0, 0, FID_STACK_INVALID, 0, 1, 0 };
struct frame_id
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index a11461d..6103287 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
2015-08-21 Pedro Alves <palves@redhat.com>
+ * tdesc.c (default_description): Explicitly zero-initialize.
+
+2015-08-21 Pedro Alves <palves@redhat.com>
+
PR gdb/18749
* inferiors.c (remove_thread): Discard any pending stop reply for
this thread.
diff --git a/gdb/gdbserver/tdesc.c b/gdb/gdbserver/tdesc.c
index 8d008fd..1263efe 100644
--- a/gdb/gdbserver/tdesc.c
+++ b/gdb/gdbserver/tdesc.c
@@ -40,7 +40,7 @@ init_target_desc (struct target_desc *tdesc)
#ifndef IN_PROCESS_AGENT
-static const struct target_desc default_description;
+static const struct target_desc default_description = { 0 };
void
copy_target_description (struct target_desc *dest,
--
1.9.3