This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Guard compile tests from running when unsupported + harden feature support check
- From: Luis Machado <lgustavo at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Wed, 19 Aug 2015 09:53:45 -0300
- Subject: [PATCH] Guard compile tests from running when unsupported + harden feature support check
- Authentication-results: sourceware.org; auth=none
In our test environment i noticed a few compile tests, though unsupported,
were still being executed and causing spurious FAIL's.
The following change adds a missing feature support check to compile-ifunc.exp
and also adds one more pattern to the feature support check function.
With this change, none of the compile tests run when they're not supposed to.
OK?
gdb/testsuite/ChangeLog:
2015-08-19 Luis Machado <lgustavo@codesourcery.com>
* lib/gdb.exp (skip_compile_feature_tests): Check for unsupported
compiler language.
* gdb.compile/compile-ifunc.exp (with_test_prefix): Check feature
support before running tests.
---
gdb/testsuite/gdb.compile/compile-ifunc.exp | 5 +++++
gdb/testsuite/lib/gdb.exp | 3 +++
2 files changed, 8 insertions(+)
diff --git a/gdb/testsuite/gdb.compile/compile-ifunc.exp b/gdb/testsuite/gdb.compile/compile-ifunc.exp
index 026c62f..80d7bb4 100644
--- a/gdb/testsuite/gdb.compile/compile-ifunc.exp
+++ b/gdb/testsuite/gdb.compile/compile-ifunc.exp
@@ -46,6 +46,11 @@ with_test_prefix "debug" {
return -1
}
+ if {[skip_compile_feature_tests]} {
+ untested "compile command not supported (could not find libcc1 shared library?)"
+ return -1
+ }
+
# gnu_ifunc (10): error: too many arguments to function 'gnu_ifunc'
gdb_test_no_output "compile code resultvar = gnu_ifunc_alias (10);"
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 56cde7a..fcf9cac 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3005,6 +3005,9 @@ proc skip_compile_feature_tests {} {
-re "Command not supported on this host\\..*\r\n$gdb_prompt $" {
set result 1
}
+ -re "No compiler support for this language\\.\r\n$gdb_prompt $" {
+ set result 1
+ }
-re "\r\n$gdb_prompt $" {
}
}
--
1.9.1