This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] btrace: indicate speculative execution
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: palves at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 06 Aug 2015 17:45:19 +0300
- Subject: Re: [PATCH] btrace: indicate speculative execution
- Authentication-results: sourceware.org; auth=none
- References: <1438867238-28224-1-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> 2015-08-06 Markus Metzger <markus.t.metzger@intel.com>
>
> * btrace.c (btrace_compute_ftrace_bts): Clear insn flags.
> (pt_btrace_insn_flags): New.
> (ftrace_add_pt): Call pt_btrace_insn_flags.
> * btrace.h (btrace_insn_flag): New.
> (btrace_insn) <flags>: New.
> * record-btrace.c (btrace_insn_history): Print insn prefix.
> * NEWS: Announce it.
>
> doc/
> * gdb.texinfo (Process Record and Replay): Document it.
doc/ has a separate ChangeLog file, so you cannot say just "Document
it." and hope people will somehow read that right after the main log
entry.
> +Speculatively executed instructions are prefixed with @code{?}. This
Please use @samp here, not code, so that the question mark is quoted
in the printed manual as well.
The documentation parts are OK with those changes.
Thanks.