This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Replace the block_found global with explicit data-flow
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre-Marie de Rodat <derodat at adacore dot com>, Doug Evans <xdje42 at gmail dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Sun, 02 Aug 2015 19:17:18 +0100
- Subject: Re: [PATCH] Replace the block_found global with explicit data-flow
- Authentication-results: sourceware.org; auth=none
- References: <55AE7520 dot 1010307 at adacore dot com> <55AE943F dot 3000009 at adacore dot com> <m3lhe4yls4 dot fsf at sspiff dot org> <55BA299D dot 7040407 at adacore dot com> <55BC89E6 dot 9040705 at adacore dot com> <55BC8CA9 dot 3070505 at adacore dot com> <55BC92D8 dot 8070407 at adacore dot com>
On 08/01/2015 10:35 AM, Pierre-Marie de Rodat wrote:
> On 08/01/2015 11:08 AM, Pierre-Marie de Rodat wrote:
>> On 08/01/2015 10:57 AM, Pierre-Marie de Rodat wrote:
>>> This is pushed, now.
>>
>> Sergio's buildbot detected a compilation error:
>>
>> ../../binutils-gdb/gdb/ft32-tdep.c: In function 'ft32_skip_prologue':
>> ../../binutils-gdb/gdb/ft32-tdep.c:253:8: error: incompatible types when
>> assigning to type 'struct symbol *' from type 'struct block_symbol'
>> sym = lookup_symbol (func_name, NULL, VAR_DOMAIN, NULL);
>>
>> Strange, I don't have this problem locally. Investigating how the
>> buildbot's build is different (mhmâ probably this --enable-targets=all).
>
> Indeed, that was the problem. I've updated my scripts to always build
> with this option, I've fixed the obvious errors (patch attached) and I
> saw no regression on x86_64-linux.
>
> Ok to push?
>
Thanks, this is OK. I went ahead and pushed this for you, to avoid
keeping the tree broken for too long.
--
Pedro Alves