This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8 09/10] Validate symbol file using build-id
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Sun, 12 Jul 2015 21:09:21 +0200
- Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <CADPb22TH5nfFSkCzW9cCiHuoJFAG+P5z=qZawgwGUgYQ5kfd5Q at mail dot gmail dot com> <20150623204702 dot GA2156 at host1 dot jankratochvil dot net> <559D3749 dot 9010200 at redhat dot com>
On Wed, 08 Jul 2015 16:44:25 +0200, Pedro Alves wrote:
> Jan Kratochvil wrote:
>
> > +static char *
> > +svr4_validate (const struct so_list *const so)
> > +{
>
> ...
>
> > + return xstrprintf (_("remote build ID is %s "
> > + "but local file does not have build ID"),
> > + remote_hex);
>
> Seems odd to say "remote" here. Can't these errors trigger with native
> debugging as well?
For this patchset not yet. The message is changed in a later patchset being
prepared where it applies also for local files.
> Doug Evans wrote:
> >
> >> > If so, having solib in the option name is confusing.
> >> >
> >> > set build-id-force
> >> > or
> >> > set require-build-id-match
> >> > or some such would be clearer.
>
> "build-id-force" sound odd to me. The latter sounds OK,
> as would "set build-id-validation on/off/...".
OK, I will change it to "set build-id-validation on/off/...".
> With that, and once the previous issues raised are
> addressed, I think this is good to go.
There patches are left without reply:
[PATCH v7 04/10] Create empty nat/linux-maps.[ch] and common/target-utils.[ch]
[PATCH v7 06/10] Prepare linux_find_memory_regions_full & co. for move
[PATCH v7 07/10] Move linux_find_memory_regions_full & co.
There particularly the [PATCH v7 06/10] contains non-mechanical (a bit)
changes.
Thanks,
Jan