This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] compile: Fix crash on cv-qualified self-reference
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org, Phil Muldoon <pmuldoon at redhat dot com>
- Date: Wed, 1 Jul 2015 18:07:13 +0200
- Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference
- Authentication-results: sourceware.org; auth=none
- References: <20150516132555 dot GB17266 at host1 dot jankratochvil dot net> <86lhf0p1hf dot fsf at gmail dot com> <20150701132406 dot GA13975 at host1 dot jankratochvil dot net> <5593F10D dot 4020903 at redhat dot com> <20150701141003 dot GA19545 at host1 dot jankratochvil dot net> <55940059 dot 30603 at redhat dot com> <20150701151202 dot GA21275 at host1 dot jankratochvil dot net> <55940636 dot 9000604 at redhat dot com> <20150701152919 dot GA23462 at host1 dot jankratochvil dot net> <559408AE dot 10904 at redhat dot com>
On Wed, 01 Jul 2015 17:35:10 +0200, Pedro Alves wrote:
> On 07/01/2015 04:29 PM, Jan Kratochvil wrote:
> > From 1 mandatory macro 3 mandatory macros and breaking all 3rd party patches.
> > When GDB codebase finally gets compiled by clang++ I agree it will be an
> > improvement.
>
> Seriously, that's a depressing and demotivating comment.
> You want it done, but you also want it not done.
Do you mean the first sentence or the second sentence?
I agree the first sentence is demotivating but I feel the same spending a lot
of time rebasing patches again and again on changes that end up half-way or
that are questionable whether they really cleaned up the code. Although
specifically for this TRY_CATCH->TRY case I had fortunately only two such
cases.
For the second sentence I hope everybody - and at least Google - agrees, that
G++ is not usable for C++ development as in many cases particularly involving
templates the error messages only say something is wrong in the source,
without giving the invalid source line number. I was bisecting the source
before I found clang++ can just report the invalid code location. I have
filed many diagnostics PRs for GCC but almost none of them are fixed yet.
G++ is great to get a bit better performing final code after all the
compilation errors are resolved by clang++.
Jan