This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Tue, 30 Jun 2015 15:08:46 +0100
- Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
- Authentication-results: sourceware.org; auth=none
- References: <CA+C-WL_ToZAgxzNZ=tSRA9hLn-+KWw-djNnRzyoiPj69BQHxoQ at mail dot gmail dot com> <1435667837-16337-1-git-send-email-patrick at parcs dot ath dot cx>
On 06/30/2015 01:37 PM, Patrick Palka wrote:
> This version adds a tui_normal_stop observer in place of augmenting the
> tui_on_sync_execution_done observer. And tui_refresh_frame_and_register_information
> can now be made a static function.
>
> The observer takes a print_frame parameter that is supposed to inform us
> whether the frame should be printed. This boolean seems to only be true for
s/only be true/only be false/
> when the inferior has exited. Since tui_refresh_frame_and_register_information
> already handles this case by checking has_stack_frames() this patch elects to
> ignore this parameter in the observer.
This is OK. I'll take a look at patch 2 soon.
Did you find that we still need deprecated_print_frame_info_listing_hook?
Thanks,
Pedro Alves