This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 30 Jun 2015 14:23:04 +0100
- Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
- Authentication-results: sourceware.org; auth=none
- References: <1435372525-1374-3-git-send-email-patrick at parcs dot ath dot cx> <1435373402-5164-1-git-send-email-patrick at parcs dot ath dot cx> <5592622D dot 40305 at redhat dot com> <CA+C-WL_ToZAgxzNZ=tSRA9hLn-+KWw-djNnRzyoiPj69BQHxoQ at mail dot gmail dot com>
On 06/30/2015 01:16 PM, Patrick Palka wrote:
>>> And as a result of this change and of the previous change to
>>> tui_show_frame_info, the TUI is much more disciplined about updating the
>>> screen, and so the flicker as described in the PR is totally gone.
>>
>> I think we should sort out patch 3 before patch 2. AFAICS, the
>> important one is this one, right?
>
> This one is more important, but by itself it causes source/asm-window
> scrolling to be reset after each command (due to the before_prompt
> observer) even if the frame information hasn't been changed in the
> meantime. Other than that they are mostly unrelated.
OK, I see.
I think I missed that because it only happens if you scroll enough to
make the highlighted source line _not_ visible. Just scrolling a bit
and entering a command is not enough to trigger it.
Thanks,
Pedro Alves