[PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type

[Patrick Palka <patrick at parcs dot ath dot cx>]

Since the type whose name is being set is now being allocated on the
gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
This reduces the number of individual valgrind warnings for the command
"gdb gdb" from ~300 to ~150.

Tested on x86_64-unknown-linux-gnu.

[ I have a few more patches on top of these that together bring the total
  number of valgrind warnings for the command "gdb gdb" down to ~30
  but they are more controversial than these two, and if these aren't OK
  then the rest definitely aren't OK.  ]

gdb/ChangeLog:

	* gdbarch.h (gdbarch_obstack_strdup): Declare.
	* gdbarch.c (gdbarch_obstack_strdup): Define.
	* gdbtypes.c (arch_type): Use it.
---
 gdb/gdbarch.c  | 10 ++++++++++
 gdb/gdbarch.h  |  5 +++++
 gdb/gdbtypes.c |  2 +-
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c
index c289334..a232177 100644
--- a/gdb/gdbarch.c
+++ b/gdb/gdbarch.c
@@ -449,6 +449,16 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size)
   return data;
 }
 
+/* See gdbarch.h.  */
+
+char *
+gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string)
+{
+  char *obstring = gdbarch_obstack_zalloc (gdbarch, strlen (string) + 1);
+  strcpy (obstring, string);
+  return obstring;
+}
+
 
 /* Free a gdbarch struct.  This should never happen in normal
    operation --- once you've created a gdbarch, you keep it around.
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 7d6a0cf..fc35136 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -1614,6 +1614,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size);
 #define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))
 #define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE)))
 
+/* Duplicate STRING, returning an equivalent string that's allocated on the
+   obstack associated with GDBARCH.  The string is freed when the corresponding
+   architecture is also freed.  */
+
+extern char *gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string);
 
 /* Helper function.  Force an update of the current architecture.
 
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 979ed6c..86c6282 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -4539,7 +4539,7 @@ arch_type (struct gdbarch *gdbarch,
   TYPE_LENGTH (type) = length;
 
   if (name)
-    TYPE_NAME (type) = xstrdup (name);
+    TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name);
 
   return type;
 }
-- 
2.5.0.rc0.5.g91e10c5.dirty