This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: gdb-patches at sourceware dot org, qiyaoltc at gmail dot com, dje at google dot com
- Date: Sun, 28 Jun 2015 01:00:30 -0300
- Subject: [PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help
- Authentication-results: sourceware.org; auth=none
>From here: https://sourceware.org/ml/gdb-patches/2015-06/msg00484.html
we concluded that, as these characters don't need to be escaped for strings
wrapped inside {} braces, we can remove the unneeded backslashes.
Ok to commit?
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/lib/gdb.exp | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 89d8e32..014132a 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-28 Martin Galvan <martin.galvan@tallertechnologies.com>
+
+ * lib/gdb.exp (test_class_help): Remove the unneeded escaping of
+ '[' and ']' characters.
+
2015-06-26 Keith Seitz <keiths@redhat.com>
Doug Evans <dje@google.com>
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index c0e0cb1..381297a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4694,11 +4694,13 @@ proc help_test_raw { gdb_command expected_lines args } {
# are regular expressions that should match the beginning of output,
# before the list of commands in that class. The presence of
# command list and standard epilogue will be tested automatically.
+# Notice that the '[' and ']' characters don't need to be escaped for strings
+# wrapped in {} braces.
proc test_class_help { command_class expected_initial_lines args } {
set l_stock_body {
- "List of commands\:.*\[\r\n\]+"
- "Type \"help\" followed by command name for full documentation\.\[\r\n\]+"
- "Type \"apropos word\" to search for commands related to \"word\"\.[\r\n\]+"
+ "List of commands\:.*[\r\n]+"
+ "Type \"help\" followed by command name for full documentation\.[\r\n]+"
+ "Type \"apropos word\" to search for commands related to \"word\"\.[\r\n]+"
"Command name abbreviations are allowed if unambiguous\."
}
set l_entire_body [concat $expected_initial_lines $l_stock_body]
--
2.4.5