This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Do not skip prologue for asm (.S) files
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Thu, 25 Jun 2015 22:37:32 +0200
- Subject: Re: [patch] Do not skip prologue for asm (.S) files
- Authentication-results: sourceware.org; auth=none
- References: <047d7bfeb318a3caf305195d7da8 at google dot com>
On Thu, 25 Jun 2015 22:30:14 +0200, Doug Evans wrote:
> Jan Kratochvil writes:
> > On Tue, 23 Jun 2015 22:35:01 +0200, Jan Kratochvil wrote:
> > > On Tue, 23 Jun 2015 01:46:08 +0200, Doug Evans wrote:
> > > > but it doesn't update sal.section nor sal.line.
> > >
> > > OK, I agree that seems wrong.
> >
> > I do not agree, it seems correct to me.
>
> I was wondering if things were correct, not stating they weren't.
Fine with that, just you have convinced me initially there is really a bug.
> Fortunately, I think there's a better way: instead of setting
> locations_valid check the language at the place where we care.
I am sure fine with that.
> Ok with this change.
Just there is now also [patchv2].
Thanks,
Jan