This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Add aarch64-linux in supports_get_siginfo_type
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Wed, 24 Jun 2015 11:45:31 +0100
- Subject: Re: [PATCH 2/2] Add aarch64-linux in supports_get_siginfo_type
- Authentication-results: sourceware.org; auth=none
- References: <1434971017-22494-1-git-send-email-yao dot qi at linaro dot org> <1434971017-22494-2-git-send-email-yao dot qi at linaro dot org>
On 06/22/2015 12:03 PM, Yao Qi wrote:
> gdbarch method get_siginfo_type is implemented on aaarch64-linux, so
> supports_get_siginfo_type should return 1 on aaarch64-linux.
typo: aaarch64.
(Patch looks obvious to me.)
I note that a few other archs are also missing here:
aarch64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
amd64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
arm-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
i386-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
m68klinux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
ppc-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
s390-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
tilegx-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
though at the pace this is taking, it'd probably be better to register
linux_get_siginfo_type as default for all Linux archs (in linux-tdep.c:linux_init_abi),
and have archs whoch kernel/ABI uses the non-generic siginfo layout install a
custom get_siginfo_type version. The supports_get_siginfo_type testsuite function
would then return true for [istarget "*-*-linux*"]. The testsuite would then help
show which archs would those be.
Thanks,
Pedro Alves