This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add tab completion for TUI's "focus" command
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>, Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 23 Jun 2015 17:52:23 +0100
- Subject: Re: [PATCH] Add tab completion for TUI's "focus" command
- Authentication-results: sourceware.org; auth=none
- References: <1434943800-9274-1-git-send-email-patrick at parcs dot ath dot cx> <CADPb22TmRqRwfEXgjJ3AzhLhWwAbQ0SmFwBO7hxQyteHmL7c9w at mail dot gmail dot com> <CA+C-WL_qFbrxEHrCH3huQPqSyE6wPOkGam8cfK1Lu0tVjxCpLw at mail dot gmail dot com> <CADPb22Q2ky2qdoMyrrnf7ndSVNoj8ZPUdof=3-HWUNbrRJ5uWw at mail dot gmail dot com>
On 06/23/2015 03:54 PM, Doug Evans wrote:
> I tried "focus cmd" and "focus src" at the start of a gdb session and
> they worked.
> I also tried "focus asm" and got a complaint of an invalid window.
> So I'd say sure, add cmd and src to the completion list
> even if TUI isn't initialized, since the command will work
> as expected. I'd add a comment to the code describing
> why they're being unconditionally added.
>
> Adding next and prev when TUI hasn't been initialized
> are kinda the odd ones out, conceptually, but they
> too "work" (so I'm not suggesting removing them).
Fully agreed.
Thanks,
Pedro Alves