Re: [PATCH] sim: cgen: namespace custom trace functions

[Mike Frysinger <vapier at gentoo dot org>]

On 14 Jun 2015 06:49, Doug Evans wrote:
> On Fri, Jun 12, 2015 at 2:11 AM, Mike Frysinger wrote:
> > The cgen code declares some macros/funcs using the trace_xxx prefix, but
> > the code isn't generic and only works with cgen targets.  This is blocking
> > the creation of new common trace functions.
> >
> > Let's blindly add cgen_xxx prefixes to all these symbols.  Some already
> > use this convention to avoid conflicts, so it makes sense to align them.
> > In the future we might want to move some to the common trace core, but
> > one thing at a time.
> >
> > I'm attaching the patch compressed because it's like 2MB in size.  It's
> > all pretty mechanical -- the large files were updated using `sed`.
> >
> > Committed.
> 
> Heads up, a lot of these are generated files.
> I'm happy to update the generator and regenerate these.

sorry about that.  i'm not terribly familiar with cgen, and the heavy use of 
scheme makes it unlikely to improve the situation :/.  looks like you posted
a patch though at this point.
-mike

Attachment: signature.asc
Description: Digital signature