This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix problems with finishing a dummy function call on simulators.
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 17 Jun 2015 14:43:39 +0100
- Subject: Re: [PATCH] Fix problems with finishing a dummy function call on simulators.
- Authentication-results: sourceware.org; auth=none
- References: <1433862056-18237-1-git-send-email-lgustavo at codesourcery dot com> <55772797 dot 802 at redhat dot com> <55805F52 dot 20805 at codesourcery dot com> <55816AD5 dot 6020605 at redhat dot com> <55817569 dot 7060704 at codesourcery dot com>
On 06/17/2015 02:26 PM, Luis Machado wrote:
> On 06/17/2015 09:40 AM, Pedro Alves wrote:
>> Yep. Close, but also remove the bp_call_dummy check in
>> bp_loc_is_permanent, and merge in its comment, like ...
>>
>
> Fixed now.
Looks good now. Thanks.
> The attached updated patch also removes this dead function. I can commit
> it as a separate patch if you're not removing it yourself.
Nah, I was hoping you'd remove it. :-) Please also remove the
make_breakpoint_permanent declaration from breakpoint.h though.
Thanks,
Pedro Alves