This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v7 02/10] Merge multiple hex conversions
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Mon, 15 Jun 2015 06:33:10 -0700
- Subject: Re: [PATCH v7 02/10] Merge multiple hex conversions
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192559 dot 18346 dot 31036 dot stgit at host1 dot jankratochvil dot net>
> gdb/gdbserver/ChangeLog
> 2014-02-26 Aleksandar Ristovski <aristovski@qnx.com
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Merge multiple hex conversions.
> * gdbreplay.c (tohex): Rename to 'fromhex'.
> (logchar): Use fromhex.
I hesitated on this one, since I was wondering why we have two
implementations of fromhex, one there, and one in rsp-low.c.
I'm guessing it's because this on in gdbreplay has a call to
"exit" (!!!). But, in the end, it seems to me that this patch
is already an improvement over the previous situation, and I'm not
really sure of the reasons behind the current implementation,
so we can leave this as is for now. (FTAOD: this is OK).
> gdb/ChangeLog
> 2014-02-26 Aleksandar Ristovski <aristovski@qnx.com
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Merge multiple hex conversions.
> * monitor.c: Include rsp-low.h.
> (fromhex): Remove definition.
OK.
--
Joel