This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- Cc: Jan-Benedict Glaw <jbglaw at lug-owl dot de>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 12 Jun 2015 08:54:39 -0400
- Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
- Authentication-results: sourceware.org; auth=none
- References: <AC542571535E904D8E8ADAE745D60B194442AD4B at IRSMSX104 dot ger dot corp dot intel dot com>
> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user
> understand what is wrong.
> In fact I did not want to wait longer to have a fix for the builds.
>
> In case you have comments on that commit please let me know I will fix
> it immediately!
I agree that a more informative error message would be welcome;
that is: explain which feature is not supported, and why it is not.
For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from
the one that was previously sent, it's customary to email the patch
to this mailing-list as well, just for archiving and also to give
everyone an opportunity to react to it, just in case.
--
Joel