This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)


> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user
> understand what is wrong. 
> In fact I did not want to wait longer to have a fix for the builds.
> 
> In case you have comments on that commit please let me know I will fix
> it immediately!

I agree that a more informative error message would be welcome;
that is: explain which feature is not supported, and why it is not.

For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from
the one that was previously sent, it's customary to email the patch
to this mailing-list as well, just for archiving and also to give
everyone an opportunity to react to it, just in case.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]