This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]
- From: Aleksandar Ristovski <ARistovski at qnx dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Gary Benson <gbenson at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 11 Jun 2015 19:46:50 +0000
- Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]
- Authentication-results: sourceware.org; auth=none
- References: <20150607200422 dot 8918 dot 48900 dot stgit at host1 dot jankratochvil dot net> <20150607200454 dot 8918 dot 52868 dot stgit at host1 dot jankratochvil dot net> <20150608083733 dot GA5405 at blade dot nx> <20150611184842 dot GA14293 at host1 dot jankratochvil dot net>
On 2015-06-11, 2:48 PM, "Jan Kratochvil" <jan.kratochvil@redhat.com> wrote:
>On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote:
>> Jan Kratochvil wrote:
>> > * common/target-utils.c: New file.
>> > * common/target-utils.h: New file.
>>
>> Nothing to do with the target should be in common. The declarations
>> should probably be in target/target.h, and they should have "target_"
>> prefixes. You could create target/target.c to put the definitions in.
>
>gdb/target/target.c would create target.o which would conflict with
>gdb/target.c.
>
>There is already gdb/target/target.h "conflicting" with gdb/target.h but
>it
>does not really conflict as gdb/target/ does not have default -I include
>dir.
>Despite for example gdb/common/ has default -I.
>
>I could propose various ideas what to move there but what is the suggested
>solution? Sure one could also for example just generate
>gdb/target-target.o
>from gdb/target/target.c.
As you say, there could be various ideas if needed, but the simplest seems
good enough to me: just move the files to target dir
common/target-utils.[hc] -> target/target_utils.[hc]
Provided Gary is happy with that solution.