This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Intercept and handle Delete/Home/End keys in the TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 10 Jun 2015 16:28:31 +0100
- Subject: Re: [PATCH] Intercept and handle Delete/Home/End keys in the TUI
- Authentication-results: sourceware.org; auth=none
- References: <1433374131-30902-1-git-send-email-patrick at parcs dot ath dot cx> <CA+C-WL-F5=6T0bczZNRMVSaJ9yB_g4zXg6w5PJQ4TpLeaZ_Lnw at mail dot gmail dot com>
On 06/04/2015 12:55 AM, Patrick Palka wrote:
> On Wed, Jun 3, 2015 at 7:28 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> These keys are mapped by wgetch() to special ncurses-specific values and
>> are otherwise passed through to readline, to no useful effect.
>>
>> This patch intercepts these keys in the TUI and gives them their
>> expected function.
>
> The commit message is slightly misleading. These keys work as
> expected when the command window is in focus. But when another window
> is in focus, these keys currently have no function. This patch gives
> them their expected function when the command window is not in focus.
I'd think it very natural that given that Up, Down, Left, Right, PageUp/PageDown
all scroll the source window, so should Home/End. When the console window is
not on focus, we can use ctrl-a / ctrl-e to move to start/end of line,
just like we use ctrl-p/ctrl-n to go "up/down" in history.
>
> Alternatively when the command window is not in focus the Home and
> Delete keys could be given the function of scrolling the source/disasm
> windows all the way up or down.
Yes, that.
> Personally I don't think that is very useful. I think the traditional binding
> would probably see more use.
I do not agree. I know I'd give lots of use to Home jumping to the
start of the file myself.
Thanks,
Pedro Alves