This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix preprocessor conditional
- From: Gary Benson <gbenson at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 9 Jun 2015 13:24:13 +0100
- Subject: Re: [PATCH] Fix preprocessor conditional
- Authentication-results: sourceware.org; auth=none
- References: <1433841679-12499-1-git-send-email-gbenson at redhat dot com>
This commit does have a ChangeLog entry; for some reason the
script I'm using didn't pick it up for the commit message :(
Gary Benson wrote:
> Hi all,
>
> This commit fixes a typo in common/fileio.c where S_IWGRP was
> misspelled as S_IWRGRP in a preprocessor conditional, causing
> Host-I/O "vFile:fstat:" and File-I/O "Fstat" and "Ffstat"
> responses to always indicate files were not group-writable
> regardless of their actual status.
>
> Pushed as obvious.
>
> Thanks,
> Gary
>
> ---
> gdb/ChangeLog | 5 +++++
> gdb/common/fileio.c | 2 +-
> 2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/common/fileio.c b/gdb/common/fileio.c
> index 28335ec..ef00ea8 100644
> --- a/gdb/common/fileio.c
> +++ b/gdb/common/fileio.c
> @@ -132,7 +132,7 @@ fileio_mode_pack (mode_t mode)
> if (mode & S_IRGRP)
> tmode |= FILEIO_S_IRGRP;
> #endif
> -#ifdef S_IWRGRP
> +#ifdef S_IWGRP
> if (mode & S_IWGRP)
> tmode |= FILEIO_S_IWGRP;
> #endif
> --
> 1.7.1
--
http://gbenson.net/