This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 07/10] Move linux_find_memory_regions_full & co.
- From: Gary Benson <gbenson at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Mon, 8 Jun 2015 09:42:27 +0100
- Subject: Re: [PATCH v6 07/10] Move linux_find_memory_regions_full & co.
- Authentication-results: sourceware.org; auth=none
- References: <20150607200422 dot 8918 dot 48900 dot stgit at host1 dot jankratochvil dot net> <20150607200518 dot 8918 dot 94373 dot stgit at host1 dot jankratochvil dot net>
Jan Kratochvil wrote:
> diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c
> index bb3eac9..462a00f 100644
> --- a/gdb/common/linux-maps.c
> +++ b/gdb/common/linux-maps.c
> @@ -18,8 +18,529 @@
>
> #ifdef GDBSERVER
> #include "server.h"
> +#include <fcntl.h>
> +#include <unistd.h>
> #else
> #include "defs.h"
> +#include "target.h"
> #endif
>
> #include "linux-maps.h"
> +#include "gdb_assert.h"
> +#include <ctype.h>
> +#include <string.h>
> +#include "target-utils.h"
> +#include "gdb_regex.h"
In addition to the comment I made previously about not using GDBSERVER
conditionals, please note that common-defs.h includes gdb_assert.h and
string.h, so these two headers should not be listed here.
> diff --git a/gdb/common/target-utils.c b/gdb/common/target-utils.c
> index 308996d..ab8991d 100644
> --- a/gdb/common/target-utils.c
> +++ b/gdb/common/target-utils.c
> @@ -23,4 +23,84 @@
> #include "defs.h"
> #endif
>
> +#include <string.h>
> #include "target-utils.h"
> +#include "gdb_assert.h"
Ditto.
Cheers,
Gary
--
http://gbenson.net/