This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Remove HISTSIZE env var altogether? (was: Re: [PATCH] Tweak the handling of $HISTSIZE edge cases [PR gdb/16999])
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 22 May 2015 11:00:31 +0100
- Subject: Remove HISTSIZE env var altogether? (was: Re: [PATCH] Tweak the handling of $HISTSIZE edge cases [PR gdb/16999])
- Authentication-results: sourceware.org; auth=none
- References: <1432248648-7402-1-git-send-email-patrick at parcs dot ath dot cx> <555E6B60 dot 8040802 at redhat dot com> <CA+C-WL-89Y2_CaOpKe_tYP1S2BvKvwgFjW-NQ90tEN6MWW7VUg at mail dot gmail dot com> <555E7B52 dot 6050100 at redhat dot com> <CA+C-WL_u3gyQyJSHMdTQjrkmWShHBJ20jkSh5acJTAqpJaHT-Q at mail dot gmail dot com> <CA+C-WL9YbXjhx13sj3UE9uxeGNQnMwTYeBt68zbjRehkzzV5Hw at mail dot gmail dot com>
Changing title to call for attention. Maybe we should ask
on gdb@. Background here:
https://sourceware.org/ml/gdb-patches/2015-05/msg00349.html
https://sourceware.org/ml/gdb-patches/2015-05/msg00563.html
> What do you think about removing HISTSIZE/GDBHISTSIZE support
> altogether? It is awfully redundant (we can already automatically set
> the history size via .gdbinit or via -ex "set history size foo") and
> thus not really useful. Even if we go along with replacing HISTSIZE
> with GDBHISTSIZE I just can't see much use for it.
What about GDBHISTFILE? I think that the rationale for the existence
of one should apply to both. (with the HISTSIZE vs GDBHISTSIZE distinction
being a separate matter.)
I'm really not sure. Trying to play devil's advocate:
#1 - An env var can be set once, for all users. But that can be
done with --with-system-gdbinit=FILE as well.
#2 - Along with GDBHISTFILE, it survives -nx. Does it really matter?
I don't know.
#3 - Seems friendly to allow at least GDBHISTFILE be an env var so it
can easily be toggled per host. Though that can be done through
Python inside .gdbinit nowadays. Though^2, Python isn't always
available.
OTOH, I'm getting more convinced that we should at least
rename HISTSIZE -> GDBHISTSIZE. The cost of keeping that
doesn't seem to be much.
Thanks,
Pedro Alves