This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb: Add completer for layout command.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Keith Seitz <keiths at redhat dot com>
- Date: Thu, 21 May 2015 01:22:46 +0200
- Subject: Re: [PATCH 2/2] gdb: Add completer for layout command.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1428011044 dot git dot andrew dot burgess at embecosm dot com> <18d55b2f3d6b65fd7e1fef8374fbadf429e95095 dot 1428011044 dot git dot andrew dot burgess at embecosm dot com> <555B3CCD dot 7040003 at redhat dot com>
* Pedro Alves <palves@redhat.com> [2015-05-19 14:38:21 +0100]:
> Sorry for the delay.
No problem. Thanks for the review.
>
> I think this should be:
>
> set test "quit command input after testing layout completion"
> gdb_test_multiple "" "$test" {
> -re "$gdb_prompt $" {
> pass $test
> }
> }
>
> so that timeout or internal error caught inside gdb_test_multiple
> use that test's message, instead of the previous'.
I have now posted a new patch series that replaces this patch. I've
addressed your review comments about the testing in my new patch. As
a bonus the new completion part of the new series is simpler and so
should not clash with Keith's work.
Thanks,
Andrew