This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/4] layout command changes


This patch set replaces an earlier patch I posted here:
  https://sourceware.org/ml/gdb-patches/2015-04/msg00185.html

In the previous patch I had to jump through some hoops in order to
support completion of the layout names like $FREGS.  This was pretty
annoying as I had not realised these layouts existed until I started
writting the completer code...

...but it turns out that those layout names don't work anyway, and
have not done so for some time.  I didn't figure out exactly when they
broke, but I believe they were broken in 6.8.

Still, it doesn't matter, as we have the 'tui regs' command, which
does work, and does allow the register set displayed in tui to be
changed.  This is for the best anyway (I think), personally, I felt
that managing both the layout, and the choice of register set all from
the layout command was too much overloading.

The first patch in this series removes the $FREGS style register set
names from the layout command, and cleans up all of the code relating
to them.

The second patch is a much simpler version of command completion
support for layout names.

The third and forth patches fix small tui related issues that I
spotted during testing.

Thanks,
Andrew

--

Andrew Burgess (4):
  gdb: Remove register class specific layout names.
  gdb: Add completer for layout command.
  gdb: Don't call tui_enable too early.
  gdb: Add cleanup to avoid memory leak on error.

 gdb/ChangeLog                         |  49 ++++++
 gdb/testsuite/ChangeLog               |   5 +
 gdb/testsuite/gdb.base/completion.exp |  19 +++
 gdb/tui/tui-data.c                    |  10 +-
 gdb/tui/tui-data.h                    |  23 ---
 gdb/tui/tui-layout.c                  | 296 +++++++++++++++-------------------
 gdb/tui/tui-layout.h                  |   3 +-
 gdb/tui/tui.c                         |   8 +-
 8 files changed, 210 insertions(+), 203 deletions(-)

-- 
2.4.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]