This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 11 May 2015 13:55:41 -0700
- Subject: Re: [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's
- Authentication-results: sourceware.org; auth=none
- References: <1431020207-14371-1-git-send-email-lgustavo at codesourcery dot com> <1431020207-14371-2-git-send-email-lgustavo at codesourcery dot com> <20150508172831 dot GC4767 at adacore dot com> <554CFF15 dot 1090206 at codesourcery dot com>
> On 05/08/2015 02:28 PM, Joel Brobecker wrote:
> >>gdb/ChangeLog:
> >>
> >>2015-05-07 Luis Machado <lgustavo@codesourcery.com>
> >>
> >> * gdb/mi/mi-cmd-var.c (mi_parse_format): Handle new "zero-hexadecimal"
> >> format.
> >> * gdb/varobj.c (varobj_format_string): Add "zero-hexadecimal" entry.
> >> (format_code): Add 'z' entry.
> >> (varobj_set_display_format): Handle FORMAT_ZHEXADECIMAL.
> >> * gdb/varobj.h (varobj_display_formats) <FORMAT_ZHEXADECIMAL>: New enum
> >> field.
> >
> >I don't normally have authority to approve, but the patch looks
> >sufficiently mechanical that I think I can provide approval if
> >the area maintainer isn't available.
[...]
> I've updated the patch with your suggestions now.
Thanks, Luis. FWIW, the patch looks good to me. Let's wait one more
week for the MI maintainer to give any feedback, but otherwise just
go ahead and push (based on the fact that it's fairly consistent with
what we already have, and a fairly mechanical change).
--
Joel