This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, May 7, 2015 at 4:30 PM, Doug Evans <dje@google.com> wrote: > Siva Chandra writes: > > This will help address libstdc++/65840: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65840 > > > > gdb/ChangeLog: > > > > 2015-04-27 Siva Chandra Reddy <sivachandra@google.com> > > > > * NEWS (Python Scripting): Mention the new gdb.Value methods. > > * python/py-value.c (valpy_reference_value): New function. > > (valpy_const_value): Likewise. > > (value_object_methods): Add new methods. > > * value.c (make_cv_value): New function. > > * value.h (make_cv_value): Declare. > > > > gdb/doc/ChangeLog: > > > > 2015-04-27 Siva Chandra Reddy <sivachandra@google.com> > > > > * python.texi (Values From Inferior): Add descriptions of new > > methods gdb.Value.reference_value and gdb.Value.const_value. > > > > gdb/testsuite/ChangeLog: > > > > 2015-04-27 Siva Chandra Reddy <sivachandra@google.com> > > > > * gdb.python/py-xmethods.cc: Enhance test case. > > * gdb.python/py-xmethods.exp: New tests. > > * gdb.python/py-xmethods.py (A_indexoper): New xmethod worker > > function. > > (B_indexoper): Likewise. > > (global_dm_list) : Add new xmethod worker functions. > > Thanks again for the ping. > > LGTM with two nits below. grep for ====. > > One more nit might be that we already have gdb.Value.referenced_value, > and now we'll also have gdb.Value.reference_value. > I'm ok with it. Thanks for the review. I have committed the attached patch after addressing the nits: 4c082a81dfebcca45e4ee8cb90490ab733b8e017
Attachment:
gdb.Value_methods_v2.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |