This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch v2 3/5, nios2] fix register save offset for signal handler trampolines


Sandra Loosemore <sandra@codesourcery.com> writes:

> It was requested that I split the patch previously posted here:
>
> https://sourceware.org/ml/gdb-patches/2015-04/msg00907.html
>
> into two parts.  This is the first part.  I also expanded the comments
> to indicate how the register save offset magic number was calculated.

Hi Sandra,
The reason I suggest to describe how this magic number is calculated in
this mail https://sourceware.org/ml/gdb-patches/2015-04/msg01038.html is
to make the code more maintainable.  Supposing some one changes the
offset in linux kernel in the future, we'll quickly know how to update
the magic number.  However, I don't insist on this...

>
> OK to commit now?

Yes, it is OK.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]