This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Add support for dumping to verilog hex format.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 23 Apr 2015 22:34:14 +0100
- Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format.
- Authentication-results: sourceware.org; auth=none
- References: <ac8db75957e27b34d78e2f0b692b5072a9809a37 dot 1429740646 dot git dot andrew dot burgess at embecosm dot com> <553821B2 dot 1080704 at redhat dot com> <20150422230431 dot GF2422 at embecosm dot com> <5538CC57 dot 6030305 at redhat dot com>
* Pedro Alves <palves@redhat.com> [2015-04-23 11:41:27 +0100]:
> Thanks, this looks good to me with the missing _() Eli noticed, and ...
The _() I wised was a result of copy 'n' pasting some code that
already lacks internationalisation support. This patch fixes those
strings in the immediate area of where I was working.
This applies on top of the verilog dump patch, and I'll push it as
obvious once that patch is merged.
Thanks,
Andrew
--
Spotted a few strings that were missing internationalization support.
gdb/ChangeLog:
* cli/cli-dump.c (srec_dump_command): Add internationalization
mark ups.
(ihex_dump_command): Likewise.
(tekhex_dump_command): Likewise.
(binary_dump_command): Likewise.
(binary_append_command): Likewise.
---
gdb/ChangeLog | 9 +++++++++
gdb/cli/cli-dump.c | 10 +++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 410f1b7..08912fd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2015-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * cli/cli-dump.c (srec_dump_command): Add internationalization
+ mark ups.
+ (ihex_dump_command): Likewise.
+ (tekhex_dump_command): Likewise.
+ (binary_dump_command): Likewise.
+ (binary_append_command): Likewise.
+
2015-04-22 Andrew Burgess <andrew.burgess@embecosm.com>
* cli/cli-dump.c (verilog_cmdlist): New variable.
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c
index 08ff941..2449dc5 100644
--- a/gdb/cli/cli-dump.c
+++ b/gdb/cli/cli-dump.c
@@ -637,14 +637,14 @@ restore_command (char *args_in, int from_tty)
static void
srec_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump srec\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump srec\" must be followed by a subcommand.\n"));
help_list (srec_cmdlist, "dump srec ", all_commands, gdb_stdout);
}
static void
ihex_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump ihex\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump ihex\" must be followed by a subcommand.\n"));
help_list (ihex_cmdlist, "dump ihex ", all_commands, gdb_stdout);
}
@@ -658,21 +658,21 @@ verilog_dump_command (char *cmd, int from_tty)
static void
tekhex_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump tekhex\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump tekhex\" must be followed by a subcommand.\n"));
help_list (tekhex_cmdlist, "dump tekhex ", all_commands, gdb_stdout);
}
static void
binary_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump binary\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump binary\" must be followed by a subcommand.\n"));
help_list (binary_dump_cmdlist, "dump binary ", all_commands, gdb_stdout);
}
static void
binary_append_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"append binary\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"append binary\" must be followed by a subcommand.\n"));
help_list (binary_append_cmdlist, "append binary ", all_commands,
gdb_stdout);
}
--
2.2.2