This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: fix xtensa build with custom overlay
- From: Pedro Alves <palves at redhat dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, gdb-patches at sourceware dot org
- Cc: Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Fri, 17 Apr 2015 17:21:41 +0100
- Subject: Re: [PATCH] gdb: fix xtensa build with custom overlay
- Authentication-results: sourceware.org; auth=none
- References: <1429287116-20216-1-git-send-email-jcmvbkbc at gmail dot com>
On 04/17/2015 05:11 PM, Max Filippov wrote:
> The commit 14e361d7aa3bbd8601b0457ee8558344e444c651 ("xtensa-config.c:
> missing defs.h include") fixed the build of default xtensa configuration
> by including defs.h in the beginning of xtensa-config.c. Unfortunately
> this fix doesn't work when gdb is configured for another xtensa core, as
> the file xtensa-config.c is a part of configuration overlay and it gets
> overwritten. To fix the build for all existing configurations include
> defs.h into gdb/xtensa-tdep.h, where the issue (reference to undeclared
> uint32_t) actually is.
Hmm, I think that's news to me. Can you please expand a bit
on why is this mechanism necessary?
In any case, that mechanism must already by outputting:
#include "xtensa-config.h"
#include "xtensa-tdep.h"
Just make it output #include "defs.h" as well?
That .c files must include defs.h is part of the standards:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
"
(...)
All other .c files under gdb/ must include defs.h as their first non-comment line.
(...)
No .h file should include defs.h, server.h or common-defs.h.
(...)
"
>
> 2015-04-17 Max Filippov <jcmvbkbc@gmail.com>
> gdb/
> * xtensa-tdep.h: Include defs.h
Note missing period.
Thanks,
Pedro Alves