This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v7 1/7] Identify remote fork event support


On 04/10/2015 06:09 PM, Don Breazeal wrote:
> @@ -6469,4 +6487,7 @@ initialize_low (void)
>    sigaction (SIGCHLD, &sigchld_action, NULL);
>  
>    initialize_low_arch ();
> +
> +  /* Enable extended ptrace events.  */
> +  linux_check_ptrace_features ();

I think the comment might have made sense possibly in a earlier revision
that added to additional ptrace options, but it looks a bit strange
now, as this isn't enabling the features yet, just checking what is
supported.  A comment like

/* Check supported ptrace features. */

would just repeat the function's signature, so I'd suggest just
dropping the comment.

Otherwise OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]