This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v7 1/7] Identify remote fork event support
- From: Pedro Alves <palves at redhat dot com>
- To: Don Breazeal <donb at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 15 Apr 2015 16:37:45 +0100
- Subject: Re: [PATCH v7 1/7] Identify remote fork event support
- Authentication-results: sourceware.org; auth=none
- References: <1428685786-18094-1-git-send-email-donb at codesourcery dot com> <1428685786-18094-2-git-send-email-donb at codesourcery dot com>
On 04/10/2015 06:09 PM, Don Breazeal wrote:
> @@ -6469,4 +6487,7 @@ initialize_low (void)
> sigaction (SIGCHLD, &sigchld_action, NULL);
>
> initialize_low_arch ();
> +
> + /* Enable extended ptrace events. */
> + linux_check_ptrace_features ();
I think the comment might have made sense possibly in a earlier revision
that added to additional ptrace options, but it looks a bit strange
now, as this isn't enabling the features yet, just checking what is
supported. A comment like
/* Check supported ptrace features. */
would just repeat the function's signature, so I'd suggest just
dropping the comment.
Otherwise OK.
Thanks,
Pedro Alves