This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/7] Access executable from remote system when first inferior appears
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 15 Apr 2015 11:24:43 +0100
- Subject: Re: [PATCH 7/7] Access executable from remote system when first inferior appears
- Authentication-results: sourceware.org; auth=none
- References: <1427887341-31819-1-git-send-email-gbenson at redhat dot com> <1427887341-31819-8-git-send-email-gbenson at redhat dot com>
On 04/01/2015 12:22 PM, Gary Benson wrote:
> This commit modifies remote_add_inferior to take an extra argument
> try_open_exec. If this is nonzero, remote_add_inferior will attempt
> to open this inferior's executable as the main executable if no main
> executable is open already. Callers are updated appropriately.
>
> One testcase required updating as a result of this commit. The test
> checked that GDB's "info files" command does not crash if no main
> executable is open, and relied on GDB's inability to access the main
> executable over the remote protocol. The test was updated to inhibit
> this new behavior.
So this is significant user-visible change too. I think it deserves
an example in the commit log, and a NEWS entry. The manual should
probably be updated to explain/mention this too. We already mention
something like this in the "attach" docs:
"When you use @code{attach}, the debugger finds the program running in
the process first (...)"
Otherwise looks good.
Thanks,
Pedro Alves