This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 06/23] Make thread_still_needs_step_over consider stepping_over_watchpoint too
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 08 Apr 2015 10:28:09 +0100
- Subject: Re: [PATCH v2 06/23] Make thread_still_needs_step_over consider stepping_over_watchpoint too
- Authentication-results: sourceware.org; auth=none
- References: <1428410990-28560-1-git-send-email-palves at redhat dot com> <1428410990-28560-7-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> +static int
> +thread_still_needs_step_over (struct thread_info *tp)
> +{
> + struct inferior *inf = find_inferior_ptid (tp->ptid);
'inf' isn't used.
> @@ -6327,6 +6357,8 @@ keep_going (struct execution_control_state *ecs)
> else
> clear_step_over_info ();
>
> + ecs->event_thread->control.trap_expected = (remove_bp || remove_wps);
> +
> /* Stop stepping if inserting breakpoints fails. */
> TRY
> {
> @@ -6341,8 +6373,6 @@ keep_going (struct execution_control_state *ecs)
> }
> END_CATCH
>
> - ecs->event_thread->control.trap_expected = (remove_bp || remove_wps);
> -
Why do we hoist this line in front of the TRY/CATCH block? because we
want to set control.trap_expected before insert_breakpoints which may
throw exception? We need a ChangeLog entry for it.
--
Yao (éå)