This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
- From: Doug Evans <dje at google dot com>
- To: Petr Machata <pmachata at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 30 Mar 2015 11:19:17 -0700
- Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
- Authentication-results: sourceware.org; auth=none
- References: <87619mkpil dot fsf at redhat dot com>
Petr Machata writes:
> Hi there,
>
> this is second iteration of my .debug_line support for dwarf.exp DWARF
> assembler. Last time around I implemented it as a macro, and the
> request was to make it a first-class section. This is now implemented.
>
> As before, only minimal support for include and file name lists is
> added, so that DW_AT_decl_file references elsewhere in DWARF file work.
>
> Thoughts?
>
> Thanks,
> Petr
Hi.
Just one nit.
Otherwise LGTM.
> + if { "$label" != "" } {
> + $label:
> + }
Should this be:
if { "$label" != "" } {
_emit "$label:"
}
?