This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
- From: Pedro Alves <palves at redhat dot com>
- To: Jon TURNEY <jon dot turney at dronecode dot org dot uk>, gdb-patches at sourceware dot org
- Date: Thu, 26 Mar 2015 09:28:33 +0000
- Subject: Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
- Authentication-results: sourceware.org; auth=none
- References: <1425646888-4332-1-git-send-email-jon dot turney at dronecode dot org dot uk> <550A0B74 dot 7030602 at redhat dot com> <550C4597 dot 5080901 at dronecode dot org dot uk> <550C5797 dot 80401 at redhat dot com> <55102584 dot 6020202 at dronecode dot org dot uk> <5512F58D dot 3050500 at dronecode dot org dot uk>
On 03/25/2015 05:51 PM, Jon TURNEY wrote:
> On 23/03/2015 14:39, Jon TURNEY wrote:
>> On 20/03/2015 17:23, Pedro Alves wrote:
>>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>>> for
>>>>>> x86_64-*-cygwin
>>>> [...]
>>>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>>>>>
>>>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>> SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>>
>>>>> OK.
>>>>
>>>> I do not have write access, so can you apply this, please.
>>>
>>> Are you planning on working on GDB further? (That'd be
>>> awesome, btw.) We can get you write access so you can
>>> push your own patches. Let me know if you'd like that.
>>
>> Yes, please.
>
> So it seems I do have write access, although I didn't know this :-)
>
:-)
> Can I go ahead and commit this?
Yes.
Please add yourself to write-after-approval section of
the gdb/MAINTAINERS file. No need for approval for that
one. Just post the patch/commit to the list for the archives.
Thanks,
Pedro Alves