This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral

From: Mike Frysinger <vapier at gentoo dot org>
To: Nicholas Clifton <nickc at redhat dot com>
Cc: dj at redhat dot com, gdb-patches at sourceware dot org
Date: Fri, 20 Mar 2015 11:40:28 -0400
Subject: Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral
Authentication-results: sourceware.org; auth=none
References: <87fv91nfy3 dot fsf at redhat dot com> <20150319184231 dot GB4128 at vapier> <550BF654 dot 7070402 at redhat dot com>

On 20 Mar 2015 10:28, Nicholas Clifton wrote:
> >>    Tested with no regressions on an rl78-elf toolchain.
> >
> > how do you really know when there are no sim tests ?
> 
> Because I use the sim to help run the gcc testsuite, and without this 
> patch several gcc tests were failing due to errors from the sim about 
> misaligned accesses to the MDB register.  With this patch those failures 
> went away and no new failures were introduced.  Hence I felt confident 
> that the patch was good.

OK.  it would be nice if there were at least one minor sim test though.
it's dirt simple to add one written in just assembly ...

i have found directed sim tests to be better than gcc in the long run.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- RFA: RL78: Fix simulation of G13 multiply/divide peripheral
  - From: Nick Clifton
- Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral
  - From: Mike Frysinger
- Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral
  - From: Nicholas Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]