This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, FT32] gdb and sim support


On 19 Mar 2015 15:21, James Bowman wrote:
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1339,9 +1340,9 @@ init.c: $(INIT_FILES)
>  	done | \
>  	while read f; do \
>  	    case " $$fs " in \
> -	        *" $$f "* ) ;; \
> -	        * ) echo $$f ; fs="$$fs $$f";; \
> -            esac; \
> +		*" $$f "* ) ;; \
> +		* ) echo $$f ; fs="$$fs $$f";; \
> +	    esac; \
>  	done >> init.l-tmp
>  	@echo '/* Do not modify this file.  */' >>init.c-tmp
>  	@echo '/* It is created automatically by the Makefile.  */'>>init.c-tmp

you should delete unrelated whitespace changes from your submission

> @@ -1870,13 +1872,13 @@ po/$(PACKAGE).pot: force
>  	    $(FLEX) -o$@ $< && \
>  	    rm -f $@.new && \
>  	    sed -e '/extern.*malloc/d' \
> -	        -e '/extern.*realloc/d' \
> -	        -e '/extern.*free/d' \
> -	        -e '/include.*malloc.h/d' \
> -	        -e 's/\([^x]\)malloc/\1xmalloc/g' \
> -	        -e 's/\([^x]\)realloc/\1xrealloc/g' \
> -	        -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
> -	        -e 's/\([ \t;,(]\)free$$/\1xfree/g' \
> +		-e '/extern.*realloc/d' \
> +		-e '/extern.*free/d' \
> +		-e '/include.*malloc.h/d' \
> +		-e 's/\([^x]\)malloc/\1xmalloc/g' \
> +		-e 's/\([^x]\)realloc/\1xrealloc/g' \
> +		-e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \
> +		-e 's/\([ \t;,(]\)free$$/\1xfree/g' \
>  		-e 's/yy_flex_xrealloc/yyxrealloc/g' \
>  	      < $@ > $@.new && \
>  	    rm -f $@ && \

this too

> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt

you've included a lot of unrelated changes in this too
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]