This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Support gzip compressed exec and core files in gdb
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Michael Eager <eager at eagerm dot com>
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Wed, 11 Mar 2015 18:15:02 +0200
- Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb
- Authentication-results: sourceware.org; auth=none
- References: <54FF77D6 dot 7010400 at eagerm dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 10 Mar 2015 16:01:42 -0700
> From: Michael Eager <eager@eagerm.com>
>
> GDB/DOC:
> * gdb.texinfo: Mention gzipped exec and core files.
This should mention the name of the node where you make changes; see
the other ChangeLog entries in gdb/doc/.
Do we need a NEWS entry for this?
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -17391,6 +17391,11 @@ via @code{gdbserver} (@pxref{Server, file, Using the @code{gdbserver}
> Program}). In these situations the @value{GDBN} commands to specify
> new files are useful.
>
> +Executable and core files may be compressed using @code{gzip}. These
'gzip' is a command, so please use @command, not @code.
> +files will be uncompressed into temporary files either in /tmp
'/tmp' is a file name, so please use @file for its markup.
> or in
> +@code{$TMPDIR} if this is set in the environment.
I'd prefer to say
in the system-wide temporary directory
and mention neither /tmp nor $TMPDIR, as both are platform-dependent.
Otherwise, the documentation parts are OK.
I agree with Mike that it's better to use library functions for
creating temporary files, since that hides platform dependencies.
Thanks.