This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

From: Mike Frysinger <vapier at gentoo dot org>
To: Chen Gang S <gang dot chen at sunrus dot com dot cn>
Cc: gdb-patches at sourceware dot org
Date: Tue, 17 Feb 2015 05:34:25 -0500
Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
Authentication-results: sourceware.org; auth=none
References: <54CC0E99 dot 1070501 at sunrus dot com dot cn>

On 31 Jan 2015 07:07, Chen Gang S wrote:
> --- a/sim/ChangeLog
> +++ b/sim/ChangeLog
> @@ -1,5 +1,10 @@
>  2014-01-31  Chen Gang <gang.chen.5i5j@gmail.com>
>  
> +	* microblaze/interp.c (sim_do_command): Call freeargv() before
> +	return.

this should be in sim/microblaze/ChangeLog instead.  it looks like your last 4 
entries in sim/ChangeLog need to get relocated.  please do so.

while you're there, you should also fix your gentmap.c entry in 
sim/common/ChangeLog -- only one space after the * is used.

as for the actual code, lgtm.  thanks for fixing up the various error paths.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
  - From: Chen Gang S

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]