This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: two agent expression nits (one line each)
- From: David Taylor <dtaylor at usendtaylorx2l dot lss dot emc dot com>
- To: Stan Shebs <stanshebs at earthlink dot net>
- Cc: Joel Brobecker <brobecker at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 03 Feb 2015 16:57:24 -0500
- Subject: Re: two agent expression nits (one line each)
- Authentication-results: sourceware.org; auth=none
- References: <14583 dot 1410458050 at usendtaylorx2l> <547E24E5 dot 8050908 at earthlink dot net> <20141213134428 dot GF5457 at adacore dot com> <23074 dot 1418658035 at usendtaylorx2l> <20141220171955 dot GG12884 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> wrote:
> Hi David,
[...]
> Since you understand what should be done, would you mind sending
> a patch in for Stan to review?
>
> --
> Joel
Joel,
Sorry for the delay. Here's the patch. Also, I haven't forgotten that
I owe you an updated patch for bad structure offsets. And I have some
others in the queue to finish up and post, as well.
Stan,
Here's the ChangeLog entries:
gdb:
2015-02-03 David Taylor <dtaylor@emc.com>
* common/ax.def (setv): Fix consumed entry in setv DEFOP.
gdb/doc:
2015-02-03 David Taylor <dtaylor@emc.com>
* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
and patch, as requested by Joel:
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 351ccdd..0118d7d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-02-03 David Taylor <dtaylor@emc.com>
+
+ * common/ax.def (setv): Fix consumed entry in setv DEFOP.
+
2015-02-02 Joel Brobecker <brobecker@adacore.com>
* dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker.
diff --git a/gdb/common/ax.def b/gdb/common/ax.def
index 8b27725..27c97cc 100644
--- a/gdb/common/ax.def
+++ b/gdb/common/ax.def
@@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29)
DEFOP (zero_ext, 1, 0, 1, 1, 0x2a)
DEFOP (swap, 0, 0, 2, 2, 0x2b)
DEFOP (getv, 2, 0, 0, 1, 0x2c)
-DEFOP (setv, 2, 0, 0, 1, 0x2d)
+DEFOP (setv, 2, 0, 1, 1, 0x2d)
DEFOP (tracev, 2, 0, 0, 1, 0x2e)
DEFOP (tracenz, 0, 0, 2, 0, 0x2f)
DEFOP (trace16, 2, 0, 1, 1, 0x30)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 9c12d9a..34fee48 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@
+2015-02-03 David Taylor <dtaylor@emc.com>
+
+ * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
+
2015-01-31 Gary Benson <gbenson@redhat.com>
Doug Evans <dje@google.com>
diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi
index 788de1c..297cd5e 100644
--- a/gdb/doc/agentexpr.texi
+++ b/gdb/doc/agentexpr.texi
@@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a
16-bit on an unaligned address raises an exception, you should fetch the
register number one byte at a time.
-@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
+@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v}
Set trace state variable number @var{n} to the value found on the top
of the stack. The stack is unchanged, so that the value is readily
available if the assignment is part of a larger expression. The