This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][PR symtab/17855] Fix.


Doug Evans <xdje42@gmail.com> writes:
> On Wed, Jan 28, 2015 at 11:19 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Aargh - I was working on it just now because I wasn't sure if anyone
>> felt they "had the ball on their court".
>>
>>> Like so?
>>>
>>> 2015-01-28  Doug Evans  <xdje42@gmail.com>
>>>
>>>       PR symtab/17855
>>>       * symfile.c (clear_symtab_users): Move call to breakpoint_re_set
>>>       closer to end.
>>
>> What I've tested is moving the call last, as shown in the attached
>> diff.  Not technically necessarily better, but as the comment explains,
>> I move it last so that it's after we've purged all relevant caches.
>> That way, the function is organized in two rough sections:
>>   - do purges first;
>>   - do updates next.
>> Your comment is a lot more detailed, I like it.
>
> I think yours is fine too.
> I'm ok with using it.

Hi.
There's value in the simplicity of your approach so I
committed it to trunk and the branch.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]