This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: [python/Ada] gdb.lookup_type fails to looking primitive type

On Wed, Jan 21, 2015 at 1:44 AM, Joel Brobecker <> wrote:
>> > Not that I'm expecting anyone to go back and change things,
>> > but maybe for future reference it'd be better to print the result
>> > and record the expected output, instead of expecting no output.
>> > Performing a lookup action, and then expecting no output,
>> > is just too confusing to me.
>> The only issue I have with that is that I'd like to do something
>> whose behavior is defined. Looking at the GDB manual, I can't see
>> anything said about what to expect when converting a gdb.Type to
>> a string... If we clarify that, I have no problem adding the extra
>> "print" in the test.
> I tried looking into the code as to what the semantics of printing
> the gdb.Type object should be, and couldn't figure it out. It seems
> to be printing the type name, but I'm not sure why. So, instead of
> waiting for a clarification that may never come, I propose the
> following.

Ah, I didn't know you were waiting on me.
I think printing the type name is just what was chosen at the time.
That choice is fine by me fwiw.

> gdb/ChangeLog:
>         * gdb.python/py-lookup-type.exp (test_lookup_type): Change
>         the second test to print the name attribute of value
>         returned by the call to gdb.lookup_type, and adjust
>         the expected output accordingly.
> Tested on x86_64-linux.
> Does this change answer your concerns?

There was no need to address anything, but thanks.
I was just making a suggestion for the next time.
[And I mean "suggestion" literally. 1/2 :-)]

The patch is fine by me.
Thanks again.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]