This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][commit] Fix regression on RHEL-5 systems (was: Re: [PATCH 2/2] Move code to disable ASR to nat/)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: sergiodj at redhat dot com (Sergio Durigan Junior)
- Cc: gdb-patches at sourceware dot org (GDB Patches), palves at redhat dot com (Pedro Alves), gbenson at redhat dot com (Gary Benson)
- Date: Mon, 19 Jan 2015 20:16:41 +0100 (CET)
- Subject: Re: [PATCH][commit] Fix regression on RHEL-5 systems (was: Re: [PATCH 2/2] Move code to disable ASR to nat/)
- Authentication-results: sourceware.org; auth=none
Sergio Durigan Junior wrote:
> On Friday, January 16 2015, Ulrich Weigand wrote:
> > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c: In function 'maybe_disable_address_space_randomization':
> > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: 'ADDR_NO_RANDOMIZE' undeclared (first use in this function)
> > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: (Each undeclared identifier is reported only once
> > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: for each function it appears in.)
>
> Ops. Thanks for letting me know, Ulrich.
>
> > It looks like this is because you replaced:
> >> -# if !HAVE_DECL_ADDR_NO_RANDOMIZE
> > by:
> >> +# ifndef HAVE_DECL_ADDR_NO_RANDOMIZE
> >
> > but config.h on my machine without ADDR_NO_RANDOMIZE contains:
> > #define HAVE_DECL_ADDR_NO_RANDOMIZE 0
>
> I took the liberty to go ahead and push the following patch as obvious.
> Please let me know if there is anything else needed.
Thanks, this does fix the problem for me.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com