This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943

Hi Sergio,

Nick's commit:

Thanks for reporting this.  I have fixed the bug with the patch below.

On a side note, I can't find Nick's message mentioning the patch on the
binutils ml.

That's because the message is in PR 17512, where a lot of the recent patches to minor file formats can be found.



2015-01-09  Nick Clifton  <>

	* tekhex.c (getvalue): Fix thinko in test for correct extraction
	of value.
	(getsym): Return false if there was not enough data to extract the

diff --git a/bfd/tekhex.c b/bfd/tekhex.c
index 9444117..94b4773 100644
--- a/bfd/tekhex.c
+++ b/bfd/tekhex.c
@@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp)

   *srcp = src;
   *valuep = value;
-  return len == 0;
+  return len == -1U;

 static bfd_boolean
@@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp, char * endp)
   dstp[i] = 0;
   *srcp = src + i;
   *lenp = len;
-  return TRUE;
+  return i == len;

 static struct data_struct *

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]