This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Don't flush the prompt when resizing the terminal within TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Thu, 08 Jan 2015 11:39:03 +0000
- Subject: Re: [PATCH 3/3] Don't flush the prompt when resizing the terminal within TUI
- Authentication-results: sourceware.org; auth=none
- References: <1420689885-31156-1-git-send-email-patrick at parcs dot ath dot cx> <1420689885-31156-3-git-send-email-patrick at parcs dot ath dot cx>
On 01/08/2015 04:04 AM, Patrick Palka wrote:
> This patch removes the ancient code that is responsible for forcing the
> prompt to get flushed and executed when tui_getc() detects that the
> terminal has been resized. This behavior is unintuitive and seemingly
> unnecessary. I tried figuring out why tui_getc() behaves this way, but
> git-blame does not reveal anything informative about this code. It
> probably has something to do with avoiding to print KEY_RESIZE keys, but
> the previous patch prevents that from happening anymore.
I don't know why it was found necessary either. I agree it's not intuitive.
Looks good to me.
Thanks,
Pedro Alves