This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] TUI: rewrite tui_query_hook()
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Thu, 08 Jan 2015 11:03:39 +0000
- Subject: Re: [PATCH] TUI: rewrite tui_query_hook()
- Authentication-results: sourceware.org; auth=none
- References: <1420689048-23538-1-git-send-email-patrick at parcs dot ath dot cx>
On 01/08/2015 03:50 AM, Patrick Palka wrote:
> This patch rewrites tui_query_hook() to print things via tui_puts() and
> to read in a line of input via wgetnstr(). The main motivation for this
> rewrite is to get the backspace key to work correctly during a quit
> prompt so that the user can revise their answer before pressing enter.
> The backspace key now works correctly because we now use getstr()
> instead of successive calls to getch().
Pagination, done in prompt_for_continue, gets away without this hook, as
it's written in terms of readline. If we did the same to defaulted_query,
I think the default code would just work for the TUI too. Did you
consider that?
Thanks,
Pedro Alves