This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/2] ISA bit treatment on the MIPS platform
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>, Doug Evans <xdje42 at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>, Rich Fuhler <rich at mips dot com>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Fri, 12 Dec 2014 14:00:44 +0000
- Subject: Re: [PATCH v2 1/2] ISA bit treatment on the MIPS platform
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1204202134510 dot 19835 at tp dot orcam dot me dot uk> <20120611182043 dot GA7597 at adacore dot com> <alpine dot DEB dot 1 dot 10 dot 1409292313170 dot 4971 at tp dot orcam dot me dot uk> <20141116103721 dot GG5774 at adacore dot com> <alpine dot DEB dot 1 dot 10 dot 1412042136450 dot 19155 at tp dot orcam dot me dot uk>
Joel, Doug --
On Thu, 4 Dec 2014, Maciej W. Rozycki wrote:
> > This is not a requirement for your patch, but if you happen to be able
> > to quickly document elf_make_msymbol_special as well, that would be
> > a very welcome and appreciated change.
>
> I have now added these descriptions, with some bias towards the MIPS
> specifics as they are what I am most familiar with. Please let me know
> if you think they might be further improved.
I haven't heard back from you, so I have applied the change now.
While reviewing the final ChangeLog entry I discovered I created an
unneeded shadow local variable definition, so in addition to the changes
already posted in this thread I have included the following cleanup, as
obvious, in the final commit.
Thanks for your review.
Maciej
gdb-mips16-isa-bit-cleanup.diff
Index: gdb-fsf-trunk-quilt/gdb/dwarf2read.c
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/dwarf2read.c 2014-12-11 23:54:46.000000000 +0000
+++ gdb-fsf-trunk-quilt/gdb/dwarf2read.c 2014-12-12 00:21:46.768928206 +0000
@@ -7027,9 +7027,6 @@ add_partial_subprogram (struct partial_d
CORE_ADDR *lowpc, CORE_ADDR *highpc,
int set_addrmap, struct dwarf2_cu *cu)
{
- struct objfile *objfile = cu->objfile;
- struct gdbarch *gdbarch = get_objfile_arch (objfile);
-
if (pdi->tag == DW_TAG_subprogram)
{
if (pdi->has_pc_info)
@@ -7041,6 +7038,7 @@ add_partial_subprogram (struct partial_d
if (set_addrmap)
{
struct objfile *objfile = cu->objfile;
+ struct gdbarch *gdbarch = get_objfile_arch (objfile);
CORE_ADDR baseaddr;
CORE_ADDR highpc;
CORE_ADDR lowpc;