This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 3/3] S390: Fix gdbserver support for TDB

Andreas Arnez wrote:

> @@ -4256,7 +4256,7 @@ regsets_fetch_inferior_registers (struct regsets_info *regsets_info,
>  		 this process mode.  */
>  	      disable_regset (regsets_info, regset);
>  	    }
> -	  else
> +	  else if (errno != ENODATA)
>  	    {
>  	      char s[256];
>  	      sprintf (s, "ptrace(regsets_fetch_inferior_registers) PID=%d",

It would be better to keep the comment explaining in what situations the kernel
can return ENODATA that you had in a previous iteration of the patch set.

> @@ -4293,7 +4293,8 @@ regsets_store_inferior_registers (struct regsets_info *regsets_info,
>        void *buf, *data;
>        int nt_type, res;
> -      if (regset->size == 0 || regset_disabled (regsets_info, regset))
> +      if (regset->size == 0 || regset_disabled (regsets_info, regset)
> +	  || regset->fill_function == NULL)
>  	continue;

This (and the related s390_fill_last_break change) is really an independent
change; maybe do it as a separate patch?  For consistency, we might likewise
want to allow regsets with NULL store_function (in regsets_fetch_inferior_registers).


  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]