This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] microMIPS support (Linux signal trampolines)

On Sun, 16 Nov 2014, Joel Brobecker wrote:

> > 	gdb/
> > 	* tramp-frame.h (tramp_frame): Add validate member.
> > 	* tramp-frame.c (tramp_frame_start): Validate trampoline before
> > 	scanning.
> > 	* mips-linux-tdep.c (MICROMIPS_INST_LI_V0): New macro.
> > 	(mips_linux_o32_sigframe): Initialize validate member.
> > 	(mips_linux_o32_rt_sigframe): Likewise.
> > 	(mips_linux_n32_rt_sigframe): Likewise.
> > 	(mips_linux_n64_rt_sigframe): Likewise.
> > 	(micromips_linux_o32_sigframe): New variable.
> > 	(micromips_linux_o32_rt_sigframe): Likewise.
> > 	(micromips_linux_n32_rt_sigframe): Likewise.
> > 	(micromips_linux_n64_rt_sigframe): Likewise.
> > 	(mips_linux_o32_sigframe_init): Handle microMIPS trampolines.
> > 	(mips_linux_n32n64_sigframe_init): Likewise.
> > 	(mips_linux_sigframe_validate): New function.
> > 	(micromips_linux_sigframe_validate): Likewise.
> > 	(mips_linux_init_abi): Install microMIPS trampoline unwinders.
> Sorry again for the late review, Maciej.

 No worries, better late than never, and I contributed to the delay in 
the first place, by keeping it all aside for two years or so.

> This patch is pre-approved, with one tiny little request:
> Can you add a quick one-liner comment as documentation for
> all the new functions? For instance:
>     /* Implement struct tramp_frame's "validate" method for [...]  */
>     static int
>     mips_linux_sigframe_validate (const struct tramp_frame *self,

 Done now, for the above and `micromips_linux_sigframe_validate' too.  
I fixed a minor formatting issue with `micromips_linux_o32_rt_sigframe' 
as well.  I have committed the change now; I think the updates are too 
insignificant to justify reposting the final version, just check the 
repository if curious.

 Thanks for your review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]