This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 3 Dec 2014 08:57:13 -0500
- Subject: Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
- Authentication-results: sourceware.org; auth=none
- References: <1417559541-32531-1-git-send-email-simon dot marchi at ericsson dot com> <20141203035550 dot GK4882 at adacore dot com>
On 2014-12-02 10:55 PM, Joel Brobecker wrote:
>> The definition does not use the typedef for the dtor function pointer
>> type that the declaration uses. It's a cosmetic-only change.
>>
>> ChangeLog:
>>
>> * common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
>> type.
>
> I would argue that this goes beyong cosmetic-only in terms of
> the benefits, so quite desirable. This is OK.
>
> Thank you!
Thanks, pushed!