This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] make "permanent breakpoints" per location and disableable
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 5 Nov 2014 14:37:24 +0800
- Subject: Re: [PATCH 2/3] make "permanent breakpoints" per location and disableable
- Authentication-results: sourceware.org; auth=none
- References: <1415127790-15091-1-git-send-email-palves at redhat dot com> <1415127790-15091-3-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
I go through this patch, and don't see anything wrong except this below,
> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
> index 118a37f..c383cd4 100644
> --- a/gdb/breakpoint.h
> +++ b/gdb/breakpoint.h
> @@ -193,12 +193,6 @@ enum enable_state
> automatically enabled and reset when the
> call "lands" (either completes, or stops
> at another eventpoint). */
> - bp_permanent /* There is a breakpoint instruction
> - hard-wired into the target's code. Don't
> - try to write another breakpoint
> - instruction on top of it, or restore its
> - value. Step over it using the
> - architecture's SKIP_INSN macro. */
> };
This causes a compilation error in guile/scm-breakpoint.c where
bp_permanent is in use.
../../../git/gdb/guile/scm-breakpoint.c: In function âbpscm_enable_state_to_stringâ:
../../../git/gdb/guile/scm-breakpoint.c:154:10: error: âbp_permanentâ undeclared (first use in this function)
case bp_permanent: return "permanent";
static const char *
bpscm_enable_state_to_string (enum enable_state enable_state)
{
switch (enable_state)
{
case bp_disabled: return "disabled";
case bp_enabled: return "enabled";
case bp_call_disabled: return "call_disabled";
case bp_permanent: return "permanent";
^^^^^^^^^^^^
default: return "unknown";
}
}
--
Yao (éå)